Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #395 and implement with alter method #398

Merged
merged 15 commits into from
Feb 13, 2024
Merged

Revert #395 and implement with alter method #398

merged 15 commits into from
Feb 13, 2024

Conversation

CanglongCl
Copy link
Collaborator

@CanglongCl CanglongCl commented Feb 9, 2024 •
edited by tisfeng
Loading

fix #399

@CanglongCl CanglongCl changed the base branch from main to dev February 9, 2024 22:13
@AkaShark AkaShark mentioned this pull request Feb 10, 2024
Closed
5 tasks
@tisfeng
Copy link
Owner

tisfeng commented Feb 10, 2024

Testing is fine.

@Jerry23011
Copy link
Collaborator

So far everything works for me, even the release version (2.6.0) works correctly after I cleaned the shortcut

@phlpsong
Copy link
Collaborator

So far everything works for me, even the release version (2.6.0) works correctly after I cleaned the shortcut

I have the same issue in #399 with release 2.6.0. This change works well from my side.

@tisfeng tisfeng force-pushed the default-value-shortcut branch from 2249ed1 to 875083a Compare February 13, 2024 02:02
@tisfeng tisfeng merged commit 319fc48 into tisfeng:dev Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkaShark AkaShark AkaShark approved these changes

@tisfeng tisfeng tisfeng approved these changes

@phlpsong phlpsong phlpsong approved these changes

@Jerry23011 Jerry23011 Jerry23011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CanglongCl @tisfeng @Jerry23011 @phlpsong @AkaShark